Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OBS canvas size as browser source default size #178

Closed
wants to merge 1 commit into from

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Oct 10, 2019

Description

This is a minor QoL change to make browser sources default to be the same size as the user's OBS canvas. For users using overlays, this should reduce the work required to add a browser source for an overlay. For all other use cases, this should not create extra work.

If the canvas width and height are not defined (I don't know why this would happen), the width and height should fallback to 800x600. Feedback on this particular section of code would be appreciated.

This PR depends on obsproject/obs-studio#2073 to maintain backwards compatibility with previously created browser sources that did not have a width and height different from the default specified.

image

Motivation and Context

At TwitchCon, some users expressed that having browser sources default to the same size as the OBS canvas would save them time/work for setting up scenes using browser source based overlays.

How Has This Been Tested?

I compiled and tested this on Windows 10 Home 1903 (Build 18362.388) 64-bit.

  1. Open OBS.
  2. Add a new browser source.

Before this change, a new browser source defaults to width 800 and height 600.
After this change, a new browser source defaults to the width and height of the OBS canvas.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.

This is a minor QoL change to make browser sources default to be the
same size as the user's OBS canvas. For users using overlays, this
should reduce the work required to add a browser source for an overlay.
For all other use cases, this should not create extra work.
@WizardCM
Copy link
Member

Challenge: this migrates all browser sources where the user hasn't changed the size from their previous size of 800x600 to the new size based on their canvas.

@WizardCM WizardCM added Duplicate Enhancement New feature or improvement labels Dec 27, 2019
@WizardCM WizardCM added the Delayed (issue) Merging has been delayed due to an issue label Dec 27, 2019
@WizardCM
Copy link
Member

As the ticket that this PR is dependent on has been cancelled/put on hold, I'm considering closing this PR for now (and likely pinning an Issue for it instead). Thoughts @cg2121 @RytoEX?

@WizardCM
Copy link
Member

WizardCM commented Mar 1, 2020

Closing this in favour of #202

@WizardCM WizardCM closed this Mar 1, 2020
@obsproject obsproject deleted a comment Aug 4, 2020
@RytoEX RytoEX deleted the change-default-size branch October 23, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Delayed (issue) Merging has been delayed due to an issue Duplicate Enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants