ignore pylint warning

ocadotechnology · Jul 19, 2024 · 77e52ee · 77e52ee
1 parent 1f95859
commit 77e52ee
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/api/serializers/agreement_signature.py b/api/serializers/agreement_signature.py
@@ -52,6 +52,9 @@ def get_agreement_commit(self, ref: str):
         # pylint: disable=line-too-long
         url = f"https://api.github.com/repos/{settings.OWNER}/{settings.REPO_NAME}/commits/{ref}"
 
+        # Set api version
+        # header: t.Dict[str, str] = {"X-GitHub-Api-Version:": "2022-11-28"}
+
         # Send an API request
         response = requests.get(url, timeout=10)
         if not response.ok:

diff --git a/api/views/agreement_signature.py b/api/views/agreement_signature.py
@@ -33,12 +33,12 @@ def get_queryset(self):
 
         return queryset
 
-    # pylint: disable-next=unused-argument
     @action(
         detail=False,
         methods=["get"],
         url_path="check-signed/(?P<contributor_pk>.+)",
     )
+    # pylint: disable=unused-argument
     def check_signed(self, _, **url_params: str):
         """
         Get the latest commit id and compare with contributor's
@@ -69,7 +69,10 @@ def check_signed(self, _, **url_params: str):
 
         # Compare agreement IDs
         if latest_commit_id == latest_signature.agreement_id:
-            return Response()
+            return Response(
+                data={"Outcome:": "Successful"},
+                status=status.HTTP_200_OK,
+            )
 
         return Response(
             data={"latest_commit_id: ": latest_commit_id},

diff --git a/api/views/agreement_signature_test.py b/api/views/agreement_signature_test.py
@@ -41,9 +41,9 @@ def test_create(self):
         self.client.create(
             data={
                 "contributor": 4,
-                "agreement_id": "4e694741a4501f224435c6adf23dd6f0122ccbf4",
+                "agreement_id": "81efd9e68f161104071f7bef7f9256e4840c1af7",
                 "signed_at": "2024-01-02T12:00:00Z",
-            }
+            },
         )
 
     def test_check_signed(self):