Validate contributors #19
Conversation
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SalmanAsh)
.github/actions/python/docs/action.yaml line 1 at r1 (raw file):
name: "Code for Life - Python - Docs"
Do we need this file in this repo?
.github/actions/python/setup-environment/action.yaml line 1 at r1 (raw file):
name: "Code for Life - Python - Setup Environment"
Same question for this one, do we need this file in this repo?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)
.github/actions/python/docs/action.yaml line 1 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Do we need this file in this repo?
Done. We don't. Deleted now.
.github/actions/python/setup-environment/action.yaml line 1 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Same question for this one, do we need this file in this repo?
Done. We don't. Deleted now.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @SalmanAsh)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SalmanAsh)
.github/scripts/python/validate-existing-contributors/Pipfile line 11 at r3 (raw file):
[dev-packages] black = "==23.1.0" pytest = "==7.2.1"
I'm not sure you need pytest here
There was a problem hiding this comment.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
.github/scripts/python/validate-existing-contributors/Pipfile line 11 at r3 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
I'm not sure you need
pytest here
Done. Removed.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SalmanAsh)
.github/scripts/python/validate-existing-contributors/Pipfile line 11 at r3 (raw file):
Previously, SalmanAsh (Salman Ashraf) wrote…
Done. Removed.
You need to re-lock after editing Pipfile
There was a problem hiding this comment.
Reviewable status: 7 of 9 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
.github/scripts/python/validate-existing-contributors/Pipfile line 11 at r3 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
You need to re-lock after editing
Pipfile
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SalmanAsh)
This change is