fix: Portal frontend 6

[SKairinos]

This change is 

[faucomte97]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)

---

src/theme/palette.ts line 14 at r1 (raw file):

declare module "@mui/material/styles" {
  interface CustomPaletteColors {
    tertiary: PaletteColor

Is this needed, is tertiary the same as student?

---

src/theme/palette.ts line 26 at r1 (raw file):

export interface PropsColorOverrides {
  tertiary: true

Same question

[SKairinos]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)

---

src/theme/palette.ts line 14 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Is this needed, is tertiary the same as student?

Yes. MUI uses the design language primary, secondary, etc. (MUI needs this) MUI uses these color names since it's a framework.

However, I gave the colors extra names tailored to our app to make it more dev friendly. Now we also have the "teacher" color, for example.

[faucomte97]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)

---

src/theme/palette.ts line 14 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

Yes. MUI uses the design language primary, secondary, etc. (MUI needs this) MUI uses these color names since it's a framework.

However, I gave the colors extra names tailored to our app to make it more dev friendly. Now we also have the "teacher" color, for example.

And how come primary and secondary aren't in there?

[SKairinos]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)

---

src/theme/palette.ts line 14 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

And how come primary and secondary aren't in there?

they are default values

[SKairinos]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)

---

src/theme/palette.ts line 14 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

they are default values

https://docs.codeforlife.education/software-developer-guide/dev-environment-setup#macos

[SKairinos]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)

---

src/theme/palette.ts line 14 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

https://docs.codeforlife.education/software-developer-guide/dev-environment-setup#macos

meant to share this link
https://mui.com/material-ui/customization/palette/#default-colors

[faucomte97]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)