add properties

codeforlife/user/models/klass.py

@@ -42,13 +42,13 @@ class Class(AbstractModel):
         ],
     )
 
-    teacher: "_teacher.Teacher" = models.ForeignKey(
+    teacher: "_teacher.Teacher" = models.ForeignKey(  # type: ignore[assignment]
         "user.Teacher",
         related_name="classes",
         on_delete=models.CASCADE,
     )
 
-    school: "_school.School" = models.ForeignKey(
+    school: "_school.School" = models.ForeignKey(  # type: ignore[assignment]
         "user.School",
         related_name="classes",
         on_delete=models.CASCADE,

codeforlife/user/models/student.py

@@ -147,8 +147,6 @@ def bulk_create_users(
         validators=[MinLengthValidator(64)],
     )
 
-    # TODO: add direct reference to teacher
-
     class Meta(TypedModelMeta):
         verbose_name = _("student")
         verbose_name_plural = _("students")
@@ -168,3 +166,14 @@ class Meta(TypedModelMeta):
                 name="student__auto_gen_password",
             ),
         ]
+
+    @property
+    def teacher(self):
+        """The student's teacher (if they have one).
+
+        Returns:
+            The student's class-teacher.
+        """
+
+        if self.klass:
+            return self.klass.teacher

codeforlife/user/models/teacher.py

@@ -15,6 +15,7 @@
 from ...models import AbstractModel
 from . import klass as _class
 from . import school as _school
+from . import student as _student
 from . import user as _user
 
 
@@ -61,8 +62,18 @@ def create_user(self, teacher: t.Dict[str, t.Any], **fields):
         help_text=_("Designates if the teacher has admin privileges."),
     )
 
-    # TODO: add direct reference to students
-
     class Meta(TypedModelMeta):
         verbose_name = _("teacher")
         verbose_name_plural = _("teachers")
+
+    @property
+    def students(self):
+        """All students in this teacher's classes.
+
+        Returns:
+            A queryset
+        """
+
+        return _student.Student.objects.filter(
+            klass_id__in=list(self.classes.values_list("id", flat=True)),
+        )

pyproject.toml

@@ -14,6 +14,7 @@ env = ["DJANGO_SETTINGS_MODULE=manage"]
 
 [tool.mypy]
 plugins = ["mypy_django_plugin.main", "mypy_drf_plugin.main"]
+check_untyped_defs = true
 
 [tool.django-stubs]
 django_settings_module = "manage"