fix: extra_kwargs again

ocadotechnology · Jan 29, 2024 · ebe5feb · ebe5feb
1 parent d64ecf4
commit ebe5feb
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 20 deletions.
diff --git a/codeforlife/user/serializers/klass.py b/codeforlife/user/serializers/klass.py
@@ -11,19 +11,30 @@
 
 # pylint: disable-next=missing-class-docstring
 class ClassSerializer(ModelSerializer[Class]):
-    id = serializers.CharField(source="access_code")
+    id = serializers.CharField(
+        source="access_code",
+        read_only=True,
+    )
 
     read_classmates_data = serializers.BooleanField(
-        source="classmates_data_viewable"
+        source="classmates_data_viewable",
+        read_only=True,
     )
 
     receive_requests_until = serializers.DateTimeField(
-        source="accept_requests_until"
+        source="accept_requests_until",
+        read_only=True,
     )
 
-    teacher = serializers.IntegerField(source="teacher.id")
+    teacher = serializers.IntegerField(
+        source="teacher.id",
+        read_only=True,
+    )
 
-    school = serializers.IntegerField(source="teacher.school.id")
+    school = serializers.IntegerField(
+        source="teacher.school.id",
+        read_only=True,
+    )
 
     # pylint: disable-next=missing-class-docstring,too-few-public-methods
     class Meta:
@@ -38,9 +49,4 @@ class Meta:
         ]
         extra_kwargs = {
             "name": {"read_only": True},
-            "id": {"read_only": True},
-            "teacher": {"read_only": True},
-            "school": {"read_only": True},
-            "read_classmates_data": {"read_only": True},
-            "receive_requests_until": {"read_only": True},
         }
diff --git a/codeforlife/user/serializers/school.py b/codeforlife/user/serializers/school.py
@@ -11,7 +11,7 @@
 
 # pylint: disable-next=missing-class-docstring
 class SchoolSerializer(ModelSerializer[School]):
-    uk_county = serializers.CharField(source="county")
+    uk_county = serializers.CharField(source="county", read_only=True)
 
     # pylint: disable-next=missing-class-docstring,too-few-public-methods
     class Meta:
@@ -26,5 +26,4 @@ class Meta:
             "id": {"read_only": True},
             "name": {"read_only": True},
             "country": {"read_only": True},
-            "uk_county": {"read_only": True},
         }
diff --git a/codeforlife/user/serializers/student.py b/codeforlife/user/serializers/student.py
@@ -11,9 +11,15 @@
 
 # pylint: disable-next=missing-class-docstring
 class StudentSerializer(ModelSerializer[Student]):
-    klass = serializers.CharField(source="class_field.access_code")
+    klass = serializers.CharField(
+        source="class_field.access_code",
+        read_only=True,
+    )
 
-    school = serializers.IntegerField(source="class_field.teacher.school.id")
+    school = serializers.IntegerField(
+        source="class_field.teacher.school.id",
+        read_only=True,
+    )
 
     # pylint: disable-next=missing-class-docstring,too-few-public-methods
     class Meta:
@@ -25,6 +31,4 @@ class Meta:
         ]
         extra_kwargs = {
             "id": {"read_only": True},
-            "klass": {"read_only": True},
-            "school": {"read_only": True},
         }
diff --git a/codeforlife/user/serializers/user.py b/codeforlife/user/serializers/user.py
@@ -11,9 +11,15 @@
 
 # pylint: disable-next=missing-class-docstring
 class UserSerializer(ModelSerializer[User]):
-    student = StudentSerializer(source="new_student")
+    student = StudentSerializer(
+        source="new_student",
+        read_only=True,
+    )
 
-    teacher = TeacherSerializer(source="new_teacher")
+    teacher = TeacherSerializer(
+        source="new_teacher",
+        read_only=True,
+    )
 
     # pylint: disable-next=missing-class-docstring,too-few-public-methods
     class Meta:
@@ -29,8 +35,6 @@ class Meta:
             "date_joined",
         ]
         extra_kwargs = {
-            "student": {"read_only": True},
-            "teacher": {"read_only": True},
             "id": {"read_only": True},
             "first_name": {"read_only": True},
             "last_name": {"read_only": True},