Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Portal frontend 50 #132

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix: Portal frontend 50 #132

merged 2 commits into from
Sep 10, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Sep 9, 2024 •
edited by faucomte97
Loading

This change is Reviewable

@SKairinos SKairinos linked an issue Sep 9, 2024 that may be closed by this pull request
teacher dashboard - refactor /classes/{id}/reset ocadotechnology/codeforlife-portal-frontend#50
Closed
faucomte97
faucomte97 reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

faucomte97
faucomte97 requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code in itself looks good but not approving yet until I understand why this is needed

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

faucomte97
faucomte97 requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)

a discussion (no related file):
Code in itself looks good but not approving yet until I understand why this is needed

faucomte97
faucomte97 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit a3fccd7 into main Sep 10, 2024
4 of 8 checks passed
@SKairinos SKairinos deleted the portal-frontend-50 branch September 10, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faucomte97 faucomte97 faucomte97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

teacher dashboard - refactor /classes/{id}/reset
2 participants
@SKairinos @faucomte97