-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Portal frontend 52 #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)
codeforlife/user/filters/klass.py
line 24 at r1 (raw file):
def id_or_name__method(self, queryset: QuerySet[Class], _: str, value: str): """Get classes where the id or the contain a substring."""
missing word
codeforlife/user/views/klass.py
line 35 at r1 (raw file):
return Class.objects.filter(students=user.student) return self.request.school_teacher_user.teacher.classes
Just double checking, where does classes
come from again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)
codeforlife/user/filters/klass.py
line 24 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
missing word
Done.
codeforlife/user/views/klass.py
line 35 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Just double checking, where does
classes
come from again?
The classes property in the teacher.py file
module path: codeforlife.user.models.SchoolTeacher.classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)