Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alter the react endpoint and remove not found for /api/ endpoint #14

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

KamilPawel
Copy link
Contributor

@KamilPawel KamilPawel commented Oct 2, 2023

This change is Reviewable

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @KamilPawel)


codeforlife/urls.py line 51 at r1 (raw file):

        ),
        re_path(
            r"^(?!.*api/).*",

should be r"^(?!api/).*"
it must not start with "api/"

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)

Copy link
Contributor Author

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


codeforlife/urls.py line 51 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

should be r"^(?!api/).*"
it must not start with "api/"

Done.

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@KamilPawel KamilPawel merged commit 8d30360 into main Oct 2, 2023
@KamilPawel KamilPawel deleted the alter-react-endpoint branch October 2, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants