Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: view permissions unit tests #57

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Jan 16, 2024

This change is Reviewable

@SKairinos
Copy link
Contributor Author

I had already created the permissions in a previous PR. In this PR I just focused on finishing the unit tests for the permissions.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 14 files at r1, 6 of 6 files at r2, 1 of 1 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


codeforlife/user/tests/permissions/test_is_teacher.py line 181 at r6 (raw file):

    Naming convention:
        test_{user_type}
    

Whitespaces

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


codeforlife/user/tests/permissions/test_is_teacher.py line 181 at r6 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Whitespaces

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 161666d into new_data_models Jan 17, 2024
2 checks passed
@SKairinos SKairinos deleted the create_view_permissions branch January 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants