Fix otp

[SKairinos]

This change is 

[SKairinos]

Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions

---

backend/Pipfile line 10 at r1 (raw file):

#   https://github.com/ocadotechnology/codeforlife-package-python/blob/{ref}/Pipfile
# Replace "{ref}" in the above URL with the ref set below.
codeforlife = {ref = "fix_otp", git = "https://github.com/ocadotechnology/codeforlife-package-python.git"}

reminder: use new version

---

backend/Pipfile line 37 at r1 (raw file):

#   https://github.com/ocadotechnology/codeforlife-package-python/blob/{ref}/Pipfile
# Replace "{ref}" in the above URL with the ref set below.
codeforlife = {ref = "fix_otp", git = "https://github.com/ocadotechnology/codeforlife-package-python.git", extras = ["dev"]}

reminder: use new version

[faucomte97]

Reviewed 7 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @SKairinos)

---

backend/api/tests/serializers/test_auth_factor.py line 32 at r1 (raw file):

        assert not self.uni_auth_factor_teacher_user.auth_factors.exists()

    # test: validate

Do we need these?

---

backend/api/tests/serializers/test_auth_factor.py line 35 at r1 (raw file):

    def test_validate_type__already_exists(self):
        """Validate type is not doing this."""

What?

---

backend/api/tests/views/test_auth_factor.py line 31 at r1 (raw file):

        assert not self.uni_auth_factor_teacher_user.auth_factors.exists()

    # test: get queryset

Do we need these?

[SKairinos]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @faucomte97)

---

backend/api/tests/serializers/test_auth_factor.py line 32 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Do we need these?

let's discuss in call.

---

backend/api/tests/serializers/test_auth_factor.py line 35 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

What?

looooooooooooooooooooooooooooooooool. Fixed.

---

backend/api/tests/views/test_auth_factor.py line 31 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Do we need these?

let's discuss in call.

[faucomte97]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)