-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to backend repo #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 102 files reviewed, 2 unresolved discussions
Pipfile
line 26 at r1 (raw file):
[packages] codeforlife = {ref = "convert_to_backend_repo", git = "https://github.com/ocadotechnology/codeforlife-package-python.git"}
install new py package
Pipfile
line 35 at r1 (raw file):
[dev-packages] codeforlife = {ref = "convert_to_backend_repo", git = "https://github.com/ocadotechnology/codeforlife-package-python.git", extras = ["dev"]}
install new py package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 100 of 102 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @SKairinos)
.devcontainer.json
line 25 at r2 (raw file):
"codecov.codecov", "ritwickdey.liveserver", "esbenp.prettier-vscode"
Why?
src/service/urls.py
line 28 at r2 (raw file):
path( "rapidrouter/", include("game.urls"),
This might be what is causing the error. RR's URLs are linked with the old portal's and therefore with home
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @faucomte97)
.devcontainer.json
line 25 at r2 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Why?
so that you can still run/debug the frontend. The FE repo is mounted in the BE devcontainer so you can still have access to it for E2E and what not. Therefore, I added all the extensions the FE needs
src/service/urls.py
line 28 at r2 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
This might be what is causing the error. RR's URLs are linked with the old portal's and therefore with
home
.
probably, yes, makes sense. let's make a separate task to resolve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions
This change is