Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to backend repo #331

Merged
merged 23 commits into from
Jun 7, 2024
Merged

Convert to backend repo #331

merged 23 commits into from
Jun 7, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Jun 7, 2024

This change is Reviewable

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 102 files reviewed, 2 unresolved discussions


Pipfile line 26 at r1 (raw file):

[packages]
codeforlife = {ref = "convert_to_backend_repo", git = "https://github.com/ocadotechnology/codeforlife-package-python.git"}

install new py package


Pipfile line 35 at r1 (raw file):

[dev-packages]
codeforlife = {ref = "convert_to_backend_repo", git = "https://github.com/ocadotechnology/codeforlife-package-python.git", extras = ["dev"]}

install new py package

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 100 of 102 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @SKairinos)


.devcontainer.json line 25 at r2 (raw file):

        "codecov.codecov",
        "ritwickdey.liveserver",
        "esbenp.prettier-vscode"

Why?


src/service/urls.py line 28 at r2 (raw file):

    path(
        "rapidrouter/",
        include("game.urls"),

This might be what is causing the error. RR's URLs are linked with the old portal's and therefore with home.

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @faucomte97)


.devcontainer.json line 25 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Why?

so that you can still run/debug the frontend. The FE repo is mounted in the BE devcontainer so you can still have access to it for E2E and what not. Therefore, I added all the extensions the FE needs


src/service/urls.py line 28 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

This might be what is causing the error. RR's URLs are linked with the old portal's and therefore with home.

probably, yes, makes sense. let's make a separate task to resolve this.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 2 unresolved discussions

@SKairinos SKairinos merged commit 339e659 into development Jun 7, 2024
10 of 11 checks passed
@SKairinos SKairinos deleted the convert_to_backend_repo branch June 7, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants