Portal frontend 6 #67

SKairinos · 2024-10-03T14:32:17Z

This change is

faucomte97

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @SKairinos)

.env line 26 at r1 (raw file):

VITE_LINK_IMPACT_REPORT_2023=https://storage.googleapis.com/codeforlife-assets/impact_reports/impact_report_2023.pdf
VITE_LINK_IDEAS_BOX=https://docs.google.com/forms/d/e/1FAIpQLSclasSZCb7s26Yax3KZuXIFhLjMhGK591WPvht0BkfjSiQR1w/viewform
VITE_LINK_HOME_LEARNING_BEGINNER=https://code-for-life.gitbook.io/independent-student-resources/beginner

Link is broken

.env line 27 at r1 (raw file):

VITE_LINK_IDEAS_BOX=https://docs.google.com/forms/d/e/1FAIpQLSclasSZCb7s26Yax3KZuXIFhLjMhGK591WPvht0BkfjSiQR1w/viewform
VITE_LINK_HOME_LEARNING_BEGINNER=https://code-for-life.gitbook.io/independent-student-resources/beginner
VITE_LINK_HOME_LEARNING_INTERMEDIATE=https://code-for-life.gitbook.io/independent-student-resources/intermediate

Link is broken

.env line 28 at r1 (raw file):

VITE_LINK_HOME_LEARNING_BEGINNER=https://code-for-life.gitbook.io/independent-student-resources/beginner
VITE_LINK_HOME_LEARNING_INTERMEDIATE=https://code-for-life.gitbook.io/independent-student-resources/intermediate
VITE_LINK_HOME_LEARNING_ADVANCED=https://code-for-life.gitbook.io/independent-student-resources/advanced

Link is broken

src/images/rr_advanced.png line 0 at r1 (raw file):
This image no longer makes sense, since there aren't any Python levels in RR anymore. We need a new pictures, maybe one that shows a Procedure level.

src/pages/homeLearning/AboutRR.tsx line 24 at r1 (raw file):

      <Typography>
        The game and lessons support the English National Curriculum Computing
        strand, and Teachers across the world love them.

Weird that "teachers" is capitalised - you can lowercase it I'd say (not blocking)

src/pages/homeLearning/AboutRR.tsx line 40 at r1 (raw file):

      <Typography>
        If you would like to keep updated on our products and receive emails
        about Code for Life, please sign up to our updates.

This needs to redirect to the newsletter form in the footer (or just the footer in general)

src/routes/paths.ts line 110 at r1 (raw file):

    scoreboard: _("/scoreboard"),
  }),
  pythonDen: _("/python-den"),

This will be a Rapid Router path

faucomte97

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

SKairinos

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

.env line 26 at r1 (raw file):