-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portal frontend 58 #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 41 of 41 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @SKairinos)
src/pages/teacherDashboard/classes/class/AdditionalClassDetails.tsx
line 28 at r1 (raw file):
<Typography> Here you can change settings and permissions for the class and the students accessing it. You can also delete classes and change level
"delete your class" instead of "delete classes" pls
src/pages/teacherDashboard/classes/class/CreateStudentsForm.tsx
line 39 at r1 (raw file):
<Typography variant="h4">Add new students</Typography> <Typography> Add the student names to the box with one name per line or separated by
If the field no longer allow for new lines, let's remove that bit from the instructions.
src/pages/teacherDashboard/classes/class/DeleteClassDialog.tsx
line 35 at r1 (raw file):
state: { notifications: [ { props: { children: "Successfully delete class." } },
deleted*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @faucomte97)
src/pages/teacherDashboard/classes/class/AdditionalClassDetails.tsx
line 28 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
"delete your class" instead of "delete classes" pls
Done.
src/pages/teacherDashboard/classes/class/CreateStudentsForm.tsx
line 39 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
If the field no longer allow for new lines, let's remove that bit from the instructions.
Done.
src/pages/teacherDashboard/classes/class/DeleteClassDialog.tsx
line 35 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
deleted*
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This change is