Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal frontend 58 #68

Merged
merged 22 commits into from
Oct 14, 2024
Merged

Portal frontend 58 #68

merged 22 commits into from
Oct 14, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Oct 11, 2024

This change is Reviewable

@SKairinos SKairinos linked an issue Oct 11, 2024 that may be closed by this pull request
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 41 of 41 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @SKairinos)


src/pages/teacherDashboard/classes/class/AdditionalClassDetails.tsx line 28 at r1 (raw file):

      <Typography>
        Here you can change settings and permissions for the class and the
        students accessing it. You can also delete classes and change level

"delete your class" instead of "delete classes" pls


src/pages/teacherDashboard/classes/class/CreateStudentsForm.tsx line 39 at r1 (raw file):

      <Typography variant="h4">Add new students</Typography>
      <Typography>
        Add the student names to the box with one name per line or separated by

If the field no longer allow for new lines, let's remove that bit from the instructions.


src/pages/teacherDashboard/classes/class/DeleteClassDialog.tsx line 35 at r1 (raw file):

              state: {
                notifications: [
                  { props: { children: "Successfully delete class." } },

deleted*

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @faucomte97)


src/pages/teacherDashboard/classes/class/AdditionalClassDetails.tsx line 28 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

"delete your class" instead of "delete classes" pls

Done.


src/pages/teacherDashboard/classes/class/CreateStudentsForm.tsx line 39 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

If the field no longer allow for new lines, let's remove that bit from the instructions.

Done.


src/pages/teacherDashboard/classes/class/DeleteClassDialog.tsx line 35 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

deleted*

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@faucomte97 faucomte97 merged commit de85a1c into development Oct 14, 2024
8 of 9 checks passed
@faucomte97 faucomte97 deleted the portal-frontend-58 branch October 14, 2024 10:53
@cfl-bot
Copy link
Collaborator

cfl-bot commented Dec 17, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

teacher dashboard - refactor /classes/{id}
3 participants