Improve query operations

ocadotechnology · Aug 6, 2024 · 6c3d1fe · 6c3d1fe
1 parent 9b93652
commit 6c3d1fe
Showing 1 changed file with 1 addition and 10 deletions.
diff --git a/portal/views/cron/user.py b/portal/views/cron/user.py
@@ -69,16 +69,7 @@ def get_inactive_users(days: int) -> QuerySet[User]:
         )
     )
 
-    teacher_queryset = user_queryset.filter(
-        new_teacher__isnull=False,
-        new_student__isnull=True,
-    )
-    independent_student_queryset = user_queryset.filter(
-        new_teacher__isnull=True,
-        new_student__class_field__isnull=True,
-    )
-
-    return teacher_queryset.union(independent_student_queryset)
+    return user_queryset.exclude(email__isnull=True).exclude(email="")
 
 
 def build_absolute_google_uri(request, location: str) -> str: