feat: Keep track of deleted unverified users #2174
Conversation
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
portal/views/cron/user.py line 62 at r1 (raw file):
) return (
instead return the 2 query sets and then get whatever data you need from them for each cron job. it isn't necessary to count in all cases
There was a problem hiding this comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @faucomte97 and @SKairinos)
portal/views/cron/user.py line 62 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
instead return the 2 query sets and then get whatever data you need from them for each cron job. it isn't necessary to count in all cases
Done.
There was a problem hiding this comment.
Reviewed 1 of 6 files at r3, all commit messages.
Reviewable status: 2 of 7 files reviewed, 2 unresolved discussions (waiting on @faucomte97)
cfl_common/common/models.py line 348 at r3 (raw file):
indy_lockout_resets = models.PositiveIntegerField(default=0) school_student_lockout_resets = models.PositiveIntegerField(default=0) anonymised_unverified_teachers = models.PositiveIntegerField(default=0)
why do we need the count now since we are preserving the data?
There was a problem hiding this comment.
Reviewed 4 of 6 files at r3.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
portal/views/cron/user.py line 62 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Done.
need to update the return type
There was a problem hiding this comment.
Reviewable status: 4 of 7 files reviewed, 1 unresolved discussion (waiting on @SKairinos)
portal/views/cron/user.py line 62 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
need to update the return type
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #2174 +/- ##
==========================================
+ Coverage 94.40% 94.43% +0.03%
==========================================
Files 166 167 +1
Lines 4555 4584 +29
==========================================
+ Hits 4300 4329 +29
Misses 255 255
|
This change is