Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update level control form #2190

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix: update level control form #2190

merged 3 commits into from
Oct 31, 2023

Conversation

SKairinos
Copy link
Collaborator

@SKairinos SKairinos commented Oct 31, 2023

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2190 (67890dd) into master (2294096) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2190      +/-   ##
==========================================
- Coverage   94.59%   94.27%   -0.33%     
==========================================
  Files         168      168              
  Lines        4590     4590              
==========================================
- Hits         4342     4327      -15     
- Misses        248      263      +15     
Files Coverage Δ
portal/views/student/play.py 97.97% <100.00%> (ø)

... and 3 files with indirect coverage changes

@SKairinos SKairinos merged commit cd1e2ed into master Oct 31, 2023
4 of 5 checks passed
@SKairinos SKairinos deleted the rr_level_control branch October 31, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants