Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move reset password email #2281

Merged
merged 58 commits into from
Apr 11, 2024
Merged

fix: move reset password email #2281

merged 58 commits into from
Apr 11, 2024

Conversation

evemartin
Copy link
Contributor

@evemartin evemartin commented Apr 10, 2024

https://r1-app.dotdigital.com/Campaigns/Step/EasyEditor.aspx?id=1557153 reset password email template


This change is Reviewable

@evemartin evemartin changed the title Move reset password email fix: move reset password email Apr 10, 2024
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @evemartin)


portal/tests/test_independent_student.py line 326 at r1 (raw file):

        page.reset_email_submit(fake_email)

        time.sleep(5)

I think you can remove this sleep now 🙂


portal/tests/test_teacher.py line 688 at r1 (raw file):

        page.reset_email_submit(fake_email)

        time.sleep(5)

Same here :)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

@faucomte97 faucomte97 merged commit e00604f into master Apr 11, 2024
5 checks passed
@faucomte97 faucomte97 deleted the move-reset-password-email branch April 11, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants