-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Remove Kurono references, URLs and functionality #2334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 55 of 56 files at r1, all commit messages.
Reviewable status: 55 of 56 files reviewed, 2 unresolved discussions (waiting on @faucomte97)
setup.py
line 34 at r1 (raw file):
"pyyaml==5.4.1", "importlib-metadata==4.13.0", # "rapid-router>=4",
reminder to uncomment
.github/workflows/ci.yml
line 33 at r1 (raw file):
pipenv install --dev --system yarn --frozen-lockfile pip install -U "git+https://github.com/ocadotechnology/rapid-router@remove_kurono#egg=rapid-router"
reminder to delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 56 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 53 of 56 files reviewed, 2 unresolved discussions (waiting on @SKairinos)
setup.py
line 34 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
reminder to uncomment
Done.
.github/workflows/ci.yml
line 33 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
reminder to delete
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 14 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
This change is