fix: Portal 2361 #2371
fix: Portal 2361 #2371
Conversation
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @SKairinos)
a discussion (no related file):
Can you please also delete the URL related to the old Python pack download and the view related to it, since we won't be needing it anymore.
portal/templates/portal/coding_club.html line 90 at r1 (raw file):
<div> <!-- TODO: improve responsiveness --> <a id="grass_snakes_pack" download class="button button--primary button--icon" href="https://3289537671-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FS5kw31UTGL8CPHU9skBS%2Fuploads%2FKsC7tdyT6htj5JX1ig28%2FGrass%20Snakes%20Club.zip?alt=media&token=1f6e6f0e-1a10-4bef-a8f8-a20b0a59e4c0">
We can leave it for mobiles but at least for desktop let's make it nicer.
I imagine that putting each <a> in a <div> should help.
portal/tests/test_daily_activities.py line 10 at r1 (raw file):
from portal.tests.base_test import BaseTest # class TestDailyActivities(BaseTest):
Just delete whole file pls
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @faucomte97)
a discussion (no related file):
Previously, faucomte97 (Florian Aucomte) wrote…
Can you please also delete the URL related to the old Python pack download and the view related to it, since we won't be needing it anymore.
Done.
portal/templates/portal/coding_club.html line 90 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
We can leave it for mobiles but at least for desktop let's make it nicer.
I imagine that putting each<a>in a<div>should help.
Done.
portal/tests/test_daily_activities.py line 10 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Just delete whole file pls
Done.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
This change is