Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev into staging #6

Merged
merged 3 commits into from
Sep 26, 2023
Merged

merge dev into staging #6

merged 3 commits into from
Sep 26, 2023

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Sep 26, 2023

This change is Reviewable

* initial

* initial code

* quick save

* install portal instead

* auth backends

* tidy up auth backends

* update auth backends

* quick save

* deploy to gcloud

* fix pipeline

* don't check migrations

* use correct service name

* no pytest

* use latest cfl packages

* quick save

* include a base url for service routing

* set base route

* use cfl package

* tests and remove user import

* session config

* quick save

* remove logout endpoint

* login working

* set session cookie domain

* return invalid form errors

* login middleware

* simplify code

* remove  login middleware

* remove extra white spacing

* update launch

* use new cfl package

* fix pipeline

* raise validation errors

* remove todos

* use latest package version

* use latest cfl package

* set secret key

* new cfl package

* fix: set env vars

* use new cfl package

* user new cfl-common package

* house keeping [skip ci]

* use latest cfl package

* feedback

* remove unnecessary return types
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 36 of 36 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 4ae6026 into staging Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants