new version email

[SKairinos]

This change is 

[SKairinos]

also need to review these email templates:
https://r1-app.dotdigital.com/Campaigns/Step/EasyEditor.aspx?id=1506387
https://r1-app.dotdigital.com/Campaigns/Step/EasyEditor.aspx?id=1512393

[faucomte97]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

[faucomte97]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)

---

CONTRIBUTING.md line 146 at r1 (raw file):

  branch.

1. On the **main** branch of your forked repo, write your email address on a new

Can this specify the needs for the chevrons please

[SKairinos]

Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @faucomte97)

---

CONTRIBUTING.md line 146 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Can this specify the needs for the chevrons please

Done.

[faucomte97]

Reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @SKairinos)

---

.github/scripts/python/notify-new-contribution-agreement/__main__.py line 44 at r3 (raw file):

    ).stdout.decode("utf-8")

    print(previous_contributing)

Do we need this print, if it prints the whole file?

---

.github/scripts/python/notify-new-contribution-agreement/__main__.py line 109 at r3 (raw file):

        diffs[1::2],
    ):
        # Only want to know which lines where removed or edited.

were*

---

.github/scripts/python/notify-new-contribution-agreement/__main__.py line 117 at r3 (raw file):

                diff_start_line_index + diff_line_index
                for diff_line_index, diff_line in enumerate(diff_lines)
                if diff_line.startswith("-")

Is this if needed if diff_lines already excludes the plusses?

[SKairinos]

Reviewable status: 5 of 6 files reviewed, 3 unresolved discussions (waiting on @faucomte97)

---

.github/scripts/python/notify-new-contribution-agreement/__main__.py line 44 at r3 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Do we need this print, if it prints the whole file?

I think it's good to have it as a sanity check. I always print the outputs of commands for debugging purposes if a workflow fails.

---

.github/scripts/python/notify-new-contribution-agreement/__main__.py line 109 at r3 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

were*

Done.

---

.github/scripts/python/notify-new-contribution-agreement/__main__.py line 117 at r3 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Is this if needed if diff_lines already excludes the plusses?

Yes because do all some lines start with "-". Some start with a blank space (" ") to signify no diff. For example, a git diff can look like this:

@@ -143,10 +143,9 @@ To sign, you must:
how to do this on GitHub. Note that you only need to fork the main
branch.

-1. On the main branch of your forked repo, create a new line at the bottom

• of this file (press Enter). Note that you must not make any other edits.

-1. Write your email address on the second last line.
+1. On the main branch of your forked repo, write your email address on a new

• line at the bottom of this file. Note that you must not make any other
• edits.

1. Commit your changes.

[faucomte97]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

[faucomte97]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)