-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dev containers for services #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @faucomte97)
.devcontainer/codeforlife-package-python/devcontainer.json
line 11 at r1 (raw file):
"remoteUser": "root", "postCreateCommand": "pipenv install --dev", "features": {
forgot pipenv
.devcontainer/codeforlife-portal-react/devcontainer.json
line 10 at r1 (raw file):
"workspaceFolder": "/workspace/codeforlife-portal-react", "remoteUser": "root", "features": {
forgot pipenv
.devcontainer/codeforlife-portal-react/devcontainer.json
line 22 at r1 (raw file):
//TODO: Specify preferred settings and extensions once defined "settings": { "python.defaultInterpreterPath": ".venv/bin/python"
backend/.venv/bin/python
.devcontainer/codeforlife-service-template/devcontainer.json
line 10 at r1 (raw file):
"workspaceFolder": "/workspace/codeforlife-service-template", "remoteUser": "root", "features": {
forgot pipenv
.devcontainer/codeforlife-service-template/devcontainer.json
line 22 at r1 (raw file):
//TODO: Specify preferred settings and extensions once defined "settings": { "python.defaultInterpreterPath": ".venv/bin/python"
backend/.venv/bin/python
.devcontainer/codeforlife-sso/devcontainer.json
line 10 at r1 (raw file):
"workspaceFolder": "/workspace/codeforlife-sso", "remoteUser": "root", "features": {
forgot pipenv
.devcontainer/codeforlife-sso/devcontainer.json
line 19 at r1 (raw file):
//TODO: Specify preferred settings and extensions once defined "settings": { "python.defaultInterpreterPath": ".venv/bin/python"
backend/.venv/bin/python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 14 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
The codeforlife-portal-react, codeforlife-workspace and the codeforlife-sso dev containers do not have a
postCreateCommand
because these services have arun
script which install the dependencies and runs a local server - I feel like this should be done by the developer manually, otherwise it might be confusing.The codeforlife-deploy-appengine dev container does not have a
postCreateCommand
because the project doesn't have properly defined requirements / dependencies.This change is