Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dev containers for services #68

Merged
merged 11 commits into from
Jan 22, 2024
Merged

Create dev containers for services #68

merged 11 commits into from
Jan 22, 2024

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Jan 18, 2024

The codeforlife-portal-react, codeforlife-workspace and the codeforlife-sso dev containers do not have a postCreateCommand because these services have a run script which install the dependencies and runs a local server - I feel like this should be done by the developer manually, otherwise it might be confusing.

The codeforlife-deploy-appengine dev container does not have a postCreateCommand because the project doesn't have properly defined requirements / dependencies.

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Jan 18, 2024
@faucomte97 faucomte97 changed the title Create dev containers for portal, RR and portal-react Create dev containers for portal, RR, portal-react and SSO Jan 18, 2024
@faucomte97 faucomte97 changed the title Create dev containers for portal, RR, portal-react and SSO Create dev containers for services Jan 19, 2024
Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @faucomte97)


.devcontainer/codeforlife-package-python/devcontainer.json line 11 at r1 (raw file):

  "remoteUser": "root",
  "postCreateCommand": "pipenv install --dev",
  "features": {

forgot pipenv


.devcontainer/codeforlife-portal-react/devcontainer.json line 10 at r1 (raw file):

  "workspaceFolder": "/workspace/codeforlife-portal-react",
  "remoteUser": "root",
  "features": {

forgot pipenv


.devcontainer/codeforlife-portal-react/devcontainer.json line 22 at r1 (raw file):

      //TODO: Specify preferred settings and extensions once defined
      "settings": {
        "python.defaultInterpreterPath": ".venv/bin/python"

backend/.venv/bin/python


.devcontainer/codeforlife-service-template/devcontainer.json line 10 at r1 (raw file):

  "workspaceFolder": "/workspace/codeforlife-service-template",
  "remoteUser": "root",
  "features": {

forgot pipenv


.devcontainer/codeforlife-service-template/devcontainer.json line 22 at r1 (raw file):

      //TODO: Specify preferred settings and extensions once defined
      "settings": {
        "python.defaultInterpreterPath": ".venv/bin/python"

backend/.venv/bin/python


.devcontainer/codeforlife-sso/devcontainer.json line 10 at r1 (raw file):

  "workspaceFolder": "/workspace/codeforlife-sso",
  "remoteUser": "root",
  "features": {

forgot pipenv


.devcontainer/codeforlife-sso/devcontainer.json line 19 at r1 (raw file):

      //TODO: Specify preferred settings and extensions once defined
      "settings": {
        "python.defaultInterpreterPath": ".venv/bin/python"

backend/.venv/bin/python

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 14 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 8f5ecd1 into main Jan 22, 2024
2 checks passed
@faucomte97 faucomte97 deleted the devcontainer branch January 22, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants