Simplify code

ocadotechnology · Dec 1, 2023 · c53f653 · c53f653
1 parent 7c1d8c2
commit c53f653
Showing 1 changed file with 10 additions and 15 deletions.
diff --git a/game/static/game/js/blocklyCustomBlocks.js b/game/static/game/js/blocklyCustomBlocks.js
@@ -9,26 +9,21 @@ function initCustomBlocks() {
 }
 
 function initCustomBlocksDescription() {
-  let fieldImage = new Blockly.FieldImage(
-      ocargo.Drawing.imageDir + CHARACTER_EN_FACE_URL,
-      ocargo.BlocklyControl.BLOCK_CHARACTER_HEIGHT,
-      ocargo.BlocklyControl.BLOCK_CHARACTER_WIDTH
-  )
-
-  if(new Date().getMonth() === 11 && CHARACTER_NAME === "Van") {
-    fieldImage = new Blockly.FieldImage(
-        ocargo.Drawing.imageDir + "characters/top_view/Sleigh.svg",
-        ocargo.BlocklyControl.BLOCK_CHARACTER_HEIGHT,
-        ocargo.BlocklyControl.BLOCK_CHARACTER_WIDTH
-    )
-  }
-
   Blockly.Blocks["start"] = {
     // Beginning block - identifies the start of the program
     init: function () {
       ocargo.blocklyControl.numStartBlocks++;
       this.setColour(50);
-      this.appendDummyInput().appendField(gettext("Start")).appendField(fieldImage);
+      this.appendDummyInput()
+        .appendField(gettext("Start"))
+        .appendField(new Blockly.FieldImage(
+          new Date().getMonth() === 11 && CHARACTER_NAME === "Van"
+            ? ocargo.Drawing.imageDir + "characters/top_view/Sleigh.svg"
+            : ocargo.Drawing.imageDir + CHARACTER_EN_FACE_URL,
+          ocargo.BlocklyControl.BLOCK_CHARACTER_HEIGHT,
+          ocargo.BlocklyControl.BLOCK_CHARACTER_WIDTH
+        )
+      );
       this.setNextStatement(true, "Action");
       this.setTooltip(gettext("The beginning of the program"));
       this.setDeletable(false);