Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level editor doesn't remember level language choice when loading a level #1436

Closed
faucomte97 opened this issue Mar 20, 2023 · 2 comments
Closed
Assignees
Labels
bug good first issue Good issue for first time contributor level editor volunteers Tasks that can be picked up by anyone

Comments

@faucomte97
Copy link
Contributor

Describe the bug
When loading a custom level, the level editor doesn't seem to remember (or load) the value of the level language (Blockly, Blockly w/ Python view or Python). It seems to default to "Blockly" even if the level has previously been saved with another option. This can cause unwanted changes in the level if the creator goes back to edit it some more and doesn't notice the wrong default value.

To Reproduce
Steps to reproduce the behaviour:

  1. Create a custom level in Rapid Router and select "Blockly with Python view" or "Python" language.
  2. Save the level and then "Play" it to confirm the right language has been saved.
  3. Go back to Create mode, and load in your new level.
  4. In the "Code" tab, notice that the Language dropdown has "Blockly" selected as default instead of your previous choice.

Expected behaviour
When loading the level and going to the "Code" tab, the Language dropdown should have the previously saved value as the default value.

@faucomte97 faucomte97 added bug good first issue Good issue for first time contributor level editor volunteers Tasks that can be picked up by anyone labels Mar 20, 2023
@sebp999 sebp999 self-assigned this Oct 6, 2023
sebp999 pushed a commit to sebp999/rapid-router that referenced this issue Oct 6, 2023
@sebp999
Copy link
Contributor

sebp999 commented Oct 6, 2023

Made a PR: #1491

@lauracumming
Copy link

Checked ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good issue for first time contributor level editor volunteers Tasks that can be picked up by anyone
Projects
None yet
Development

No branches or pull requests

3 participants