Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1436: load custom level should set correct language #1491

Merged
merged 8 commits into from
Dec 20, 2023

Conversation

sebp999
Copy link
Contributor

@sebp999 sebp999 commented Oct 6, 2023

Description

Bug fix for #1436 : the language (Blockly/Python/both) not being set correctly when a custom level is loaded

How Has This Been Tested?

  • Added a test that the data is saved correctly.
  • Ran unit and end-to-end tests

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x ] I have linked this PR to a ZenHub Issue.

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sebp999)


game/tests/test_level_editor.py line 336 at r1 (raw file):

        assert new_level.pythonViewEnabled is True
        assert new_level.pythonEnabled is False
        assert new_level.blocklyEnabled is True

Let's just have assert x for True and assert not x for False, no need to specify them at the end 🙂

Code quote:

        assert new_level.pythonViewEnabled is True
        assert new_level.pythonEnabled is False
        assert new_level.blocklyEnabled is True

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sebp999)

@faucomte97 faucomte97 merged commit cad596b into ocadotechnology:master Dec 20, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants