feat: Create levels 110-122 #1509
Conversation
There was a problem hiding this comment.
Reviewed 4 of 9 files at r1, all commit messages.
Reviewable status: 4 of 9 files reviewed, all discussions resolved (waiting on @faucomte97)
There was a problem hiding this comment.
Reviewable status: 4 of 9 files reviewed, 2 unresolved discussions (waiting on @faucomte97)
game/migrations/0086_loop_levels.py line 460 at r1 (raw file):
Episode = apps.get_model("game", "Episode") for levelID in range(110, 154):
Don't pull these into memory. Do a bulk delete on the sql server instead.
Level.objects.filter(id__in=range(110, 154)).delete()
game/migrations/0086_loop_levels.py line 471 at r1 (raw file):
Episode.objects.get(pk=14).delete() Episode.objects.get(pk=13).delete() Episode.objects.get(pk=12).delete()
bulk delete
There was a problem hiding this comment.
Reviewed 1 of 9 files at r1.
Reviewable status: 5 of 9 files reviewed, 2 unresolved discussions (waiting on @faucomte97)
There was a problem hiding this comment.
Reviewable status: 5 of 9 files reviewed, 2 unresolved discussions (waiting on @faucomte97 and @SKairinos)
game/migrations/0086_loop_levels.py line 460 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
Don't pull these into memory. Do a bulk delete on the sql server instead.
Level.objects.filter(id__in=range(110, 154)).delete()
Done.
game/migrations/0086_loop_levels.py line 471 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
bulk delete
Done.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
game/migrations/0086_loop_levels.py line 460 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Done.
Have you tested this? Does it not break because episode_109 has a FK to episode_110?
game/migrations/0086_loop_levels.py line 471 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Done.
Have you tested this? Does it not break because episode_11 has a FK to episode_12?
There was a problem hiding this comment.
Reviewed 1 of 9 files at r1, 1 of 1 files at r2.
Reviewable status: 7 of 9 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
There was a problem hiding this comment.
Reviewed 1 of 9 files at r1.
Reviewable status: 8 of 9 files reviewed, 2 unresolved discussions (waiting on @faucomte97)
game/static/game/js/blocklyControl.js line 327 at r2 (raw file):
n += count(conditionBlock); } else if (block.type === "variables_get" || block.type === "math_number") { n++
validate that parent is directly or indirectly connected to start block
There was a problem hiding this comment.
Reviewable status: 8 of 9 files reviewed, 3 unresolved discussions (waiting on @faucomte97)
game/static/game/js/blocklyControl.js line 324 at r2 (raw file):
n += count(nextBlock); } else if (block.type === "logic_negate" || block.type === "logic_compare") { var conditionBlock = block.inputList[0].connection.targetBlock();
validate that children are connected to start block
There was a problem hiding this comment.
Reviewed 1 of 9 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
There was a problem hiding this comment.
Reviewable status:
game/migrations/0086_loop_levels.py line 471 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
Have you tested this? Does it not break because episode_11 has a FK to episode_12?
must do
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
==========================================
- Coverage 91.66% 91.58% -0.08%
==========================================
Files 110 110
Lines 5793 5870 +77
==========================================
+ Hits 5310 5376 +66
- Misses 483 494 +11
|
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
This PR:
This change is