Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: While loop final checks #1513

Merged
merged 7 commits into from
Nov 3, 2023
Merged

fix: While loop final checks #1513

merged 7 commits into from
Nov 3, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Nov 3, 2023

  • Grey out coming soon episodes
  • Make hint & level fail / complete popups buttons match styles of start level popup
  • Change level 109 title and description as it's no longer the final challenge

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1513 (4a4595e) into master (4ff42ff) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1513   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files         110      110           
  Lines        5864     5864           
=======================================
  Hits         5377     5377           
  Misses        487      487           
Files Coverage Δ
game/messages.py 99.06% <100.00%> (ø)

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit fa5b02a into master Nov 3, 2023
5 checks passed
@faucomte97 faucomte97 deleted the while_loop_final_checks branch November 3, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants