Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1476-Video sound keeps playing after closing the popup it's in #1554

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

AbdelrahmanDeghedy
Copy link
Contributor

@AbdelrahmanDeghedy AbdelrahmanDeghedy commented Dec 10, 2023

Description

How Has This Been Tested?

stopVideoAfterPopup.webm

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AbdelrahmanDeghedy)


game/static/game/js/drawing.js line 1020 at r1 (raw file):

  // https://gist.github.com/cferdinandi/9044694
  const video = document.getElementsByClassName("video");
  var iframeSrc = video[0].src;

Can you replace var with let please 🙏 😊

@AbdelrahmanDeghedy
Copy link
Contributor Author

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AbdelrahmanDeghedy)

game/static/game/js/drawing.js line 1020 at r1 (raw file):

  // https://gist.github.com/cferdinandi/9044694
  const video = document.getElementsByClassName("video");
  var iframeSrc = video[0].src;

Can you replace var with let please 🙏 😊

I have replaced it with a const since it's not mutated.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AbdelrahmanDeghedy)

@faucomte97 faucomte97 merged commit 86b9884 into ocadotechnology:master Dec 15, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants