Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add python den game pages #1682

Merged
merged 24 commits into from
Aug 20, 2024
Merged

feat: add python den game pages #1682

merged 24 commits into from
Aug 20, 2024

Conversation

evemartin
Copy link
Contributor

@evemartin evemartin commented Jul 23, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1, 2 of 3 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @evemartin)


game/static/game/css/backgrounds.css line 25 at r3 (raw file):

.bg--advanced {
    background-color: #754fc8;
}

Remove these since it seems we don't need it anymore? Check for other instances of these keywords too please

Code quote:

.bg--hard {
    background-color: #8967d3;
}

.bg--advanced {
    background-color: #754fc8;
}

game/static/game/css/backgrounds.css line 37 at r3 (raw file):

.bg--loops-coming-soon {
    background-color: #CBCBCB;
}

Remove these since it seems we don't need it anymore? Check for other instances of these keywords too please

Code quote:

.bg--loops {
    background-color: #3F3F3F;
}

.bg--loops-coming-soon {
    background-color: #CBCBCB;
}

game/static/game/css/game.css line 415 at r3 (raw file):

    width: 120px;
    opacity: 0;
}

The Exit button gets too small when the screen sizes get smaller - maybe see if you can set a minimum size so it's still visible enough

Code quote:

.header-exit-button {
    position: absolute;
    left: 0px;
    height: 50px;
    width: 120px;
    opacity: 0;
}

game/static/game/css/game.css line 423 at r3 (raw file):

:root {
    --rpf-button-primary-background-color: #ffd23b !important;
    --rpf-button-primary-text-color: black !important;

What are these for? 🤔

Code quote:

    --rpf-button-primary-background-color: #ffd23b !important;
    --rpf-button-primary-text-color: black !important;

game/templates/game/game.html line 165 at r3 (raw file):

      <input type="radio" name="tabs" id="python_radio">
      <label for="python_radio">
        <span>{% trans "Python Den" %}</span>

Clicking this makes the workspace and console windows disappear? 🤯

Copy link
Contributor Author

@evemartin evemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @faucomte97)


game/static/game/css/game.css line 415 at r3 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

The Exit button gets too small when the screen sizes get smaller - maybe see if you can set a minimum size so it's still visible enough

As we discussed during the handover call: the weird thing about this is that the exit button icon is actually also part of the header, I'm just using an invisible button placed over the header to actually function as the button - this makes it difficult to resize the exit button. However, this was originally added because the IDE levels won't have the exit tab button even though all the other levels do, so since we're pushing the IDE stuff back, we might be able to just crop the header for now


game/static/game/css/game.css line 423 at r3 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

What are these for? 🤔

These were to change the color of the IDE's run button but aren't needed anymore!

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 7 of 8 files reviewed, 4 unresolved discussions (waiting on @evemartin)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r5, 1 of 1 files at r6.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @evemartin)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @evemartin)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

@faucomte97 faucomte97 merged commit c6462aa into master Aug 20, 2024
5 checks passed
@faucomte97 faucomte97 deleted the python-den-game-page branch August 20, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants