Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Python Den scoreboard #1726

Merged
merged 11 commits into from
Sep 6, 2024
Merged

feat: Python Den scoreboard #1726

merged 11 commits into from
Sep 6, 2024

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Sep 5, 2024

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Sep 5, 2024
@faucomte97 faucomte97 linked an issue Sep 5, 2024 that may be closed by this pull request
4 tasks
@faucomte97 faucomte97 marked this pull request as ready for review September 6, 2024 14:12
@faucomte97 faucomte97 enabled auto-merge (squash) September 6, 2024 14:22
Copy link
Contributor

@evemartin evemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


game/views/level_selection.py line 252 at r1 (raw file):

        python_episodes = get_python_episodes(request)

        print(python_episodes)

Please remove leftover print

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 16 of 17 files reviewed, 1 unresolved discussion (waiting on @evemartin)


game/views/level_selection.py line 252 at r1 (raw file):

Previously, evemartin wrote…

Please remove leftover print

Done.

Copy link
Contributor

@evemartin evemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 6a3c526 into master Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Den scoreboard
2 participants