Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Python Den level 15 model solution #1736

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Sep 30, 2024

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Sep 30, 2024
@faucomte97 faucomte97 linked an issue Sep 30, 2024 that may be closed by this pull request
3 tasks
@faucomte97 faucomte97 enabled auto-merge (squash) September 30, 2024 12:56
Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


game/migrations/0102_reorder_episodes_13_14.py line 0 at r1 (raw file):
Don't think it's a good idea to rename the migration if it's already been applied. Django keeps track of applied migrations by name in the django_migrations table.

You'll need to:

  1. Delete the old migration from this table
  2. Add the new migration using --fake

Given the risk of breaking the database state for a simple rename, I vote to avoid this course of action.

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @SKairinos)


game/migrations/0102_reorder_episodes_13_14.py line at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

Don't think it's a good idea to rename the migration if it's already been applied. Django keeps track of applied migrations by name in the django_migrations table.

You'll need to:

  1. Delete the old migration from this table
  2. Add the new migration using --fake

Given the risk of breaking the database state for a simple rename, I vote to avoid this course of action.

I hate typos. But fine.

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 59fa7c1 into master Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Den - solution amends
2 participants