Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow cows to be placed on a non-road square #1746

Conversation

RaihanRasheedApurbo
Copy link
Contributor

@RaihanRasheedApurbo RaihanRasheedApurbo commented Oct 18, 2024

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

@faucomte97 faucomte97 linked an issue Oct 21, 2024 that may be closed by this pull request
1 task
@RaihanRasheedApurbo RaihanRasheedApurbo changed the title allow cows to be placed on a non-road square fix: allow cows to be placed on a non-road square Oct 28, 2024
@RaihanRasheedApurbo RaihanRasheedApurbo force-pushed the Allow-for-cows-to-be-placed-on-a-non-road-square branch from d8ff18f to 64de4e3 Compare October 28, 2024 01:13
@RaihanRasheedApurbo
Copy link
Contributor Author

@faucomte97 I have created an MR for signing the contributor agreement. I have read the process. My understanding is that I will receive an email if you action something on the MR.

I think we need to do this first before we can validate-existing-contributors / validate-existing-contributors workflow in this MR.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @RaihanRasheedApurbo)

a discussion (no related file):
Hi @RaihanRasheedApurbo, I've manually tested this PR and it looks like I'm not able to play a level where I've placed cows on the grass (not on the road).

The map doesn't finish loading and I get this error:

image.png


@RaihanRasheedApurbo
Copy link
Contributor Author

@faucomte97 can you do another manual test and see if its okay now? Since I haven't worked on this code repo before, I don't know all the potential places things can break. So there is a chance that you might find another bug. I am sorry for this inconvenience.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RaihanRasheedApurbo)

@faucomte97 faucomte97 merged commit 94b9fe0 into ocadotechnology:master Nov 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for cows to be placed on a non-road square
2 participants