-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow cows to be placed on a non-road square #1746
fix: allow cows to be placed on a non-road square #1746
Conversation
d8ff18f
to
64de4e3
Compare
@faucomte97 I have created an MR for signing the contributor agreement. I have read the process. My understanding is that I will receive an email if you action something on the MR. I think we need to do this first before we can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @RaihanRasheedApurbo)
a discussion (no related file):
Hi @RaihanRasheedApurbo, I've manually tested this PR and it looks like I'm not able to play a level where I've placed cows on the grass (not on the road).
The map doesn't finish loading and I get this error:
@faucomte97 can you do another manual test and see if its okay now? Since I haven't worked on this code repo before, I don't know all the potential places things can break. So there is a chance that you might find another bug. I am sorry for this inconvenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RaihanRasheedApurbo)
Description
How Has This Been Tested?
Checklist:
This change is