Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid cow squares remain highlighted #1752

Conversation

RaihanRasheedApurbo
Copy link
Contributor

@RaihanRasheedApurbo RaihanRasheedApurbo commented Dec 7, 2024

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

@RaihanRasheedApurbo RaihanRasheedApurbo force-pushed the invalid-cow-squares-remain-highlighted-#1643 branch from 343634d to d568b71 Compare December 7, 2024 20:04
@RaihanRasheedApurbo RaihanRasheedApurbo changed the title fix: invalid cow squares remain highlighted (#1643) fix: invalid cow squares remain highlighted Dec 7, 2024
@RaihanRasheedApurbo
Copy link
Contributor Author

I have looked at the failed test's log. I don't know why it failed and how it could be related to the changes I made. I checked out master and ran the tests and it failed as well. Let me know what you think? @faucomte97

@SKairinos SKairinos linked an issue Dec 9, 2024 that may be closed by this pull request
@faucomte97
Copy link
Contributor

Hi @RaihanRasheedApurbo, I'm looking into this now - it is weird, and what's weirder is that I'm getting different error logs locally. I'll let you know what I find, but as of now it looks like an issue on our side.

@faucomte97
Copy link
Contributor

Hi again @RaihanRasheedApurbo, the tests have passed after a few times of me rerunning them which confirms this is an flakiness issue on our side. I will now review your PR 🙂

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RaihanRasheedApurbo)

@faucomte97 faucomte97 merged commit a436679 into ocadotechnology:master Dec 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid cow squares remain highlighted
2 participants