Add a poisonable Barrier to picos_std.sync
#351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polytypic
force-pushed
the
add-poisonable-barrier
branch
9 times, most recently
from
00b43aa to
a33ada3
Compare
polytypic
force-pushed
the
add-poisonable-barrier
branch
from
a33ada3 to
e7cd15d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a slim poisonable barrier to
picos_std.sync— the barrier state and configuration is stored in a singleint Awaitable.t. The state of the barrier is mostly updated usingfetch_and_add, which should perform well.In the future the bit manipulation logic could probably be tweaked or the OCaml compiler improved save a few instructions. The potential performance improvement from that is likely to be tiny, however.