chore: hardcode unix and threads library in bootstrap #11624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
fix-bootstrap-promotion
branch
from
fb25cdf to
63e99b5
Compare
Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
fix-bootstrap-promotion
branch
from
63e99b5 to
b1e0eec
Compare
maiste
reviewed
Apr 14, 2025
| @@ -64,11 +64,8 @@ let rule sctx ~requires_link = | |||
| ]) | |||
| |> Action_builder.of_memo | |||
| in | |||
| let externals = | |||
There was a problem hiding this comment.
I understand that Dune generates the thread.posix every time, but I don't understand where it comes from. What is a change in the compiler?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discussed that we should be doing something like this in #11199.