Always pass --site with unsafe-yes

ocaml · Jun 21, 2024 · 0200e1c · 0200e1c
1 parent e8ae49b
commit 0200e1c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/master_changes.md b/master_changes.md
@@ -59,6 +59,7 @@ users)
 ## Opamfile
 
 ## External dependencies
+ * Correct flags passed to Cygwin setup for external installations [#6045 @dra27 fixes #6041]
 
 ## Format upgrade
 

diff --git a/src/state/opamSysInteract.ml b/src/state/opamSysInteract.ml
@@ -1039,9 +1039,7 @@ let install_packages_commands_t ?(env=OpamVariable.Map.empty) config sys_package
      ] @ (if Cygwin.is_internal config then
             let common =
               [ "--upgrade-also";
-                "--only-site";
                 "--no-write-registry";
-                "--site"; Cygwin.mirror;
                 "--local-package-dir";
                 OpamFilename.Dir.to_string (Cygwin.internal_cygcache ());
               ]
@@ -1050,7 +1048,10 @@ let install_packages_commands_t ?(env=OpamVariable.Map.empty) config sys_package
               "--symlink-type" :: "native" :: common
             else
               common
-          else [])
+          else []) @ (if Cygwin.is_internal config || unsafe_yes then
+            [ "--only-site";
+              "--site"; Cygwin.mirror;
+            ])
     ],
     None
   | Debian ->