GHA: Several fixes on depexts workflow #6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecognised as centos
ENV FOO foo to ENV FOO=foo
kit-ty-kate
reviewed
Jul 9, 2024
| RUN yum install -y $mainlibs $ocaml | ||
| RUN yum install -y gcc-c++ | ||
| RUN yum install -y gcc-c++ diffutils | ||
| RUN sed -i 's/ID="almalinux"/ID="centos"/' /etc/os-release |
There was a problem hiding this comment.
i don't think we should try to emulate centos
There was a problem hiding this comment.
centos is effectively a dead platform as far as the community goes. Trying to emulate a distribution that is diverging is a bad idea
There was a problem hiding this comment.
It is a dead platform true, but there are still users on it, and it is still supported by opam.
Almalinux is meant to be a replacement to centos, providing backward compatibility. Until it diverges completely, it is a good testing platform for centos jobs.
We could add a full support for almalinux & rockylinux, but that's another issue, and they should have their own jobs.
…ps, to have them cached and not computed each time
kit-ty-kate
approved these changes
Jul 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major ones:
os-versionto checkBackport to 2.2 by #6086