Make it so pin list display the current revision of the pinned repo #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In particular, may the url or revision be empty for a git/hs/darcs kind? |
rjbou
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Thank you for you PR!
You'll find some comments specific to the implementation the implementation.
To complete the PR, it needs also to:
- add a test (we can do it)
- update the list manpage text to inform about the new column, especially that it is the hash of the current state of the source, not the installed one.
- polishing (remove trailing whitespace, indent, 80 columns), but we will do it at the end.
A todo for the dev team: we'll need to add a more exhaustive test to pin, existing one tests only the several kind of pin (vcs/path/version), but not the not synchronised package.
kit-ty-kate
requested changes
Oct 29, 2024
|
side remark on the code itself: many of the lines of code added by this PR contain a trailing whitespace. It would be nice to avoid them |
|
Thanks for your review, I'll be working on implementing them |
kit-ty-kate
approved these changes
Oct 29, 2024
|
Discussed on dev meeting: We end up converging to this syntax |
kit-ty-kate
reviewed
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of issue #5533
It works, but I'm not sure it's the best way to do it