Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not close in ExplainPhysicalOperator #300

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

stevelee477
Copy link
Contributor

What problem were solved in this pull request?

Problem: do not close child operator in ExplainPhysicalOperator

How to reproduce:

create table a (a int);
create index idx on a(a);
explain delete from a where a=1;

cause SegFault, because trying to close IndexScanPhysicalOperator, but not open

What is changed and how it works?

Just do not close child oper in ExplainPhysicalOperator::close

Copy link
Collaborator

@hnwyllmm hnwyllmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hnwyllmm hnwyllmm merged commit abf5ba7 into oceanbase:main Oct 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants