Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove features in devcontainer #348

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

hnwyllmm
Copy link
Collaborator

@hnwyllmm hnwyllmm commented Mar 4, 2024

What problem were solved in this pull request?

Problem:
oceanbase/miniob 镜像中已经把需要的依赖都加上了,如果还需要其它依赖,应该调整miniob镜像。
而且在国内安装devcontainer features中描述的组件,特别慢。

What is changed and how it works?

删除devcontainer文件中features相关内容

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.99%. Comparing base (c9e9bb7) to head (264d4ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   36.99%   36.99%           
=======================================
  Files         101      101           
  Lines        7272     7272           
=======================================
  Hits         2690     2690           
  Misses       4582     4582           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hnwyllmm hnwyllmm merged commit 95d941d into oceanbase:main Mar 4, 2024
14 checks passed
@hnwyllmm hnwyllmm deleted the devcontainer branch March 4, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant