downland delete progress_bar (#554)

* downland delete progress_bar * downland delete progress_bar
oceanbase · Nov 14, 2024 · 7637458 · 7637458
1 parent f48a0b0
commit 7637458
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/common/ssh_client/remote_client.py b/common/ssh_client/remote_client.py
@@ -115,7 +115,7 @@ def download(self, remote_path, local_path):
         transport = self._ssh_fd.get_transport()
         self._sftp_client = paramiko.SFTPClient.from_transport(transport)
         self.stdio.verbose('Download {0}:{1}'.format(self.host_ip, remote_path))
-        self._sftp_client.get(remote_path, local_path, callback=self.progress_bar)
+        self._sftp_client.get(remote_path, local_path)
         self._sftp_client.close()
 
     def progress_bar(self, transferred, to_be_transferred, suffix=''):

diff --git a/test/common/ssh_client/test_remote_client.py b/test/common/ssh_client/test_remote_client.py
@@ -204,7 +204,7 @@ def test_download_success(self, mock_from_transport):
         self.remote_client.download(remote_path, local_path)
 
         # Verify that the get method was called once with the correct parameters during the download process
-        self.remote_client._sftp_client.get.assert_called_once_with(remote_path, local_path, callback=self.remote_client.progress_bar)
+        self.remote_client._sftp_client.get.assert_called_once_with(remote_path, local_path)
 
         # Verify that the close method was called once after the download completes
         self.remote_client._sftp_client.close.assert_called_once()
@@ -243,7 +243,7 @@ def test_download_failure(self, mock_from_transport):
             self.remote_client.download(remote_path, local_path)
 
         # Confirm that the get method was called once with the correct parameters
-        self.remote_client._sftp_client.get.assert_called_once_with(remote_path, local_path, callback=self.remote_client.progress_bar)
+        self.remote_client._sftp_client.get.assert_called_once_with(remote_path, local_path)
 
         # Manually call the close method to mimic actual behavior
         self.remote_client._sftp_client.close()