Merge pull request #709 from oclif/mdonnalley/json

fix: all error and warnings to stderr, this.log in commands
oclif · Nov 8, 2023 · 7b8cb30 · 7b8cb30
2 parents b3eb9e9 + 6bdba67
commit 7b8cb30
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/commands/plugins/install.ts b/src/commands/plugins/install.ts
@@ -165,7 +165,7 @@ e.g. If you have a core plugin that has a 'hello' command, installing a user-ins
 
       YarnMessagesCache.getInstance().flush(plugin)
 
-      ux.log(chalk.green(`\nSuccessfully installed ${plugin.name} v${plugin.version}`))
+      this.log(chalk.green(`\nSuccessfully installed ${plugin.name} v${plugin.version}`))
     }
   }
 }

diff --git a/src/util.ts b/src/util.ts
@@ -131,10 +131,10 @@ export class YarnMessagesCache {
     }
 
     if (plugin) {
-      ux.log(`\nThese warnings can only be addressed by the owner(s) of ${plugin.name}.`)
+      ux.logToStderr(`\nThese warnings can only be addressed by the owner(s) of ${plugin.name}.`)
 
       if (plugin.pjson.bugs || plugin.pjson.repository) {
-        ux.log(
+        ux.logToStderr(
           `We suggest that you create an issue at ${
             plugin.pjson.bugs ?? plugin.pjson.repository
           } and ask the plugin owners to address them.\n`,
@@ -143,7 +143,7 @@ export class YarnMessagesCache {
     }
 
     if (YarnMessagesCache.errors.size === 0) return
-    ux.log('\nThe following errors occurred:')
+    ux.logToStderr('\nThe following errors occurred:')
     for (const err of YarnMessagesCache.errors) {
       ux.error(err, {exit: false})
     }
-Original file line number
+Diff line change
@@ Expand Up @@
           YarnMessagesCache.getInstance().flush(plugin)
-          ux.log(chalk.green(`\nSuccessfully installed ${plugin.name} v${plugin.version}`))
+          this.log(chalk.green(`\nSuccessfully installed ${plugin.name} v${plugin.version}`))
         }
       }
     }
@@ Expand Down @@