-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: migrate to ESM #683
Changes from 9 commits
6ff57ad
5630d42
4bbf966
37743d4
f635621
88e9d02
ec52b94
699e926
dbdb4df
a071ef1
ab8f9cd
59f9a98
9f3c4bc
aaab8ec
1a483fa
196a2e8
4567aaa
9902fbc
460f2e4
94ca767
e607a77
e270ed3
abc3fe0
29e64ff
f11e12b
bc54d05
aa628ab
5ef2429
2be40c4
42bd760
aa86e2a
f68c98c
e803fe1
cb39c84
5b58de1
05e7a7e
779dac6
aacc034
b462f16
9d3a916
f4bb41e
0558f23
a67753f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"extends": ["@commitlint/config-conventional"] | ||
} |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"extends": ["oclif", "oclif-typescript", "prettier"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,10 @@ | ||
{ | ||
"productTag": "a1aB0000000ce2IIAQ", | ||
"defaultBuild": "offcore.tooling.55", | ||
"issueTypeLabels": { "enhancement": "USER STORY", "bug": "BUG P3" }, | ||
"defaultBuild": "offcore.tooling.59", | ||
"issueTypeLabels": { | ||
"enhancement": "USER STORY", | ||
"bug": "BUG P3" | ||
}, | ||
"hideWorkItemUrl": true, | ||
"statusWhenClosed": "CLOSED" | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: create-github-release | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
# point at specific branches, or a naming convention via wildcard | ||
- prerelease/** | ||
tags-ignore: | ||
- '*' | ||
workflow_dispatch: | ||
inputs: | ||
prerelease: | ||
type: string | ||
description: 'Name to use for the prerelease: beta, dev, etc. NOTE: If this is already set in the package.json, it does not need to be passed in here.' | ||
|
||
jobs: | ||
release: | ||
# this job will throw if prerelease is true but it doesn't have a prerelease-looking package.json version | ||
uses: salesforcecli/github-workflows/.github/workflows/create-github-release.yml@main | ||
secrets: | ||
SVC_CLI_BOT_GITHUB_TOKEN: ${{ secrets.SVC_CLI_BOT_GITHUB_TOKEN }} | ||
with: | ||
prerelease: ${{ inputs.prerelease }} | ||
# If this is a push event, we want to skip the release if there are no semantic commits | ||
# However, if this is a manual release (workflow_dispatch), then we want to disable skip-on-empty | ||
# This helps recover from forgetting to add semantic commits ('fix:', 'feat:', etc.) | ||
skip-on-empty: ${{ github.event_name == 'push' }} |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ on: | |
workflow_dispatch: | ||
|
||
jobs: | ||
integration-tests: | ||
sf-integration-tests: | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, windows-latest] | ||
|
@@ -22,12 +22,26 @@ jobs: | |
retry_wait_seconds: 60 | ||
command: npm install -g @salesforce/cli@$nightly --omit=dev | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what does the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think it does anything - it probably was a typo and we got lucky that npm doesn't care??? |
||
timeout_minutes: 60 | ||
- name: Build project | ||
run: | | ||
yarn | ||
yarn build | ||
- uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main | ||
- run: yarn build | ||
- name: Run tests | ||
run: yarn test:integration:sf | ||
|
||
integration-tests: | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, windows-latest] | ||
test: ['test:integration:install', 'test:integration:link'] | ||
runs-on: ${{matrix.os}} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: lts/* | ||
- uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main | ||
- run: yarn build | ||
- name: Run tests | ||
run: yarn test:integration | ||
run: yarn ${{matrix.test}} | ||
|
||
unit-tests: | ||
uses: salesforcecli/github-workflows/.github/workflows/unitTest.yml@main |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,6 @@ | |
/lib | ||
/node_modules | ||
/tmp | ||
|
||
oclif.lock | ||
oclif.manifest.json |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#!/bin/sh | ||
. "$(dirname $0)/_/husky.sh" | ||
|
||
yarn run commitlint --edit $1 | ||
yarn commitlint --edit $1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
yarn lint-staged --concurrent false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"*.json": ["prettier --write"], | ||
"*.md": ["prettier --write"], | ||
"+(src|test)/**/*.+(ts|js)": ["eslint --fix", "prettier --write"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,8 @@ | ||
{ | ||
"require": [ | ||
"test/helpers/init.js", | ||
"ts-node/register", | ||
"source-map-support/register" | ||
], | ||
"watch-extensions": [ | ||
"ts" | ||
], | ||
"require": ["ts-node/register"], | ||
"watch-extensions": ["ts"], | ||
"recursive": true, | ||
"reporter": "spec", | ||
"timeout": 200000 | ||
} | ||
"timeout": 200000, | ||
"node-option": ["loader=ts-node/esm"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
"@oclif/prettier-config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oclif might not have the same concurrent job limits as Salesforce so maybe we should spread these around a bit?