fix: handle spaces in node/npm path #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: forcedotcom/cli#2564
Follow-up from: #711
The fix in 711 worked on my windows box because:
plugin-pluginsget the path to the npm-cli.js from the bundled one, which in my case it didn't contain a space in the path so only quoting the node bin path was enough.When using a windows installer, both the node binary and npm-cli.js file come from the same CLI dir so both need to be double-quoted when passed to shelljs.exec.
plugin-trust does the same: https://github.com/salesforcecli/plugin-trust/blob/01b8161e22a59991e924ec491fc5c99dc409a796/src/shared/npmCommand.ts#L64
@ W-14480077@