fix: disable autoupdates entirely when env var is set

oclif · May 9, 2018 · 8328b4f · 8328b4f
1 parent 7bccd1a
commit 8328b4f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/src/commands/update.ts b/src/commands/update.ts
@@ -98,7 +98,6 @@ export default class UpdateCommand extends Command {
 
   private async skipUpdate(): Promise<string | false> {
     if (!this.config.binPath) return this.config.scopedEnvVar('UPDATE_INSTRUCTIONS') || 'not updatable'
-    if (this.autoupdate && this.config.scopedEnvVar('DISABLE_AUTOUPDATE') === '1') return 'autoupdates disabled'
     const manifest = await this.fetchManifest()
     if (this.config.version === manifest.version) {
       if (this.config.scopedEnvVar('HIDE_UPDATED_MESSAGE')) return 'done'

diff --git a/src/hooks/init.ts b/src/hooks/init.ts
@@ -19,6 +19,7 @@ async function mtime(f: string) {
 
 export const init: Config.Hook<'init'> = async function (opts) {
   if (opts.id === 'update') return
+  if (opts.config.scopedEnvVarTrue('DISABLE_AUTOUPDATE')) return
   cli.config.errlog = opts.config.errlog
   const binPath = this.config.binPath || this.config.bin
   const lastrunfile = path.join(this.config.cacheDir, 'lastrun')