Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to ESM #269

Merged
merged 5 commits into from
Oct 10, 2023
Merged

feat!: migrate to ESM #269

merged 5 commits into from
Oct 10, 2023

Conversation

mdonnalley
Copy link
Contributor

BREAKING CHANGES: node 18 minimum, removed exports

BREAKING CHANGES: node 18 minimum, removed exports
@git2gus
Copy link

git2gus bot commented Oct 10, 2023

This issue has been linked to a new work item: W-14268190

@mshanemc
Copy link
Member

QA:

sf plugins install @oclif/[email protected]
✅ got the unsigned warning

✅ help works with both -h and --help

sf version

 ›   Warning: Plugin @oclif/plugin-version (1.3.11-qa.0) differs from the version specified by sf (1.3.10)
@salesforce/cli/2.13.6 darwin-x64 node-v18.15.0

sf version --json

{
  "architecture": "darwin-x64",
  "cliVersion": "@salesforce/cli/2.13.6",
  "nodeVersion": "node-v18.15.0"
}

also looked fine --verbose, --verbose --json

crossing updates

sf update stable
✅ all the above tests looked good on stable non-esm CLI

[install, then update back to an ESM cli]
sf plugins uninstall @oclif/plugin-version
sf plugins install @oclif/[email protected]
sf update nightly

✅ all the above tests looked good back on nightly

@mshanemc mshanemc merged commit 85f1947 into main Oct 10, 2023
5 checks passed
@mshanemc mshanemc deleted the mdonnalley/esm branch October 10, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants