Add text alignment to SliderFloat just like Button #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make this generic I would suggest renaming `ButtonTextAlign` to `TextAlign` and using it for many other controls as well. Alternatively adding multiple text align styles for each control type would be possible too although not necessary since this style can be edited before drawing each control by the user. This would have no performance impact as `RenderTextClipped` already processes alignment anyway.
|
Thanks for the PR. I agree this is desirable. There's however a catch with applying it to every widgets: text editable widgets currently needs to left aligned to be able to aim with the mouse cursor. Ideally the internal code for Would you mind sharing a screenshot of how you are currently aligning things with your patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this generic I would suggest renaming
ButtonTextAligntoTextAlignand using it for many other controls as well. Alternatively adding multiple text align styles for each control type would be possible too although not necessary since this style can be edited before drawing each control by the user. This would have no performance impact asRenderTextClippedalready processes alignment anyway.