Add cmake interface support #2033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good, ill peek at it once it is accepted and make changes to it if needed. |
ocornut
force-pushed
the
master
branch
2 times, most recently
from
0c1e5bd to
bb6a60b
Compare
ocornut
force-pushed
the
master
branch
2 times, most recently
from
8b83e0a to
d735066
Compare
ocornut
force-pushed
the
master
branch
2 times, most recently
from
b3b85d8 to
0755767
Compare
ocornut
force-pushed
the
master
branch
3 times, most recently
from
c817acb to
8d39063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for cmake install using library interface. Added to support Hunter package manager, https://github.com/ruslo/hunter. Specifics for imgui are at, ruslo/hunter#1521. Once Hunter's PR is accepted and a release created there will be package documentation at https://docs.hunter.sh/en/latest/packages/pkg/imgui.html.
This PR is not required for Hunter to work as required changes are hosted here https://github.com/hunter-packages/imgui, however it is better when the main line supports it and the changes are not Hunter specific just cmake. Also I can create a PR for a Hunter Badge for imgui's readme if this is something you all want.