Backends: WebGPU: include imgui.h before backend check #8437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backend check would always fail in non-Emscripten settings because imgui.h, and transitively imconfig.h, would not yet be included at this point in the code.
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend check would always fail in non-Emscripten settings because
imgui, and transitivelyimconfig.h, would not be included at this point in the code. The result is the following compile error, which modifyingimconfig.hwould not solve. (This issue can be worked around by supplying the definition via the build system.)I'm trying to get IMGUI working with WebGPU under Dawn. I encountered this issue; afterwards there are some other compile issues that I need to solve.